Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: removed removeWebdavAccount method #33355

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore!: removed removeWebdavAccount method #33355

merged 2 commits into from
Oct 1, 2024

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Sep 25, 2024 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

remove removeWebdavAccount meteor method as it is replaced by webdav.removeWebdavAccount endpoint.

Issue(s)

Steps to test or reproduce

Further comments

CORE-357

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6f665e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 25, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33355/
on branch gh-pages at 2024-10-01 01:10 UTC

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@3de08fc). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33355   +/-   ##
================================================
  Coverage                 ?   75.32%           
================================================
  Files                    ?      383           
  Lines                    ?    19383           
  Branches                 ?     4980           
================================================
  Hits                     ?    14601           
  Misses                   ?     4212           
  Partials                 ?      570
Flag Coverage Δ
unit 75.32% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin marked this pull request as ready for review September 25, 2024 16:30
@abhinavkrin abhinavkrin requested review from a team as code owners September 25, 2024 16:30
@abhinavkrin abhinavkrin force-pushed the chore/removed-removeWebdavAccount-method branch from 3658952 to f8eb7ad Compare September 25, 2024 16:32
ggazzo
ggazzo requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it's a breakchange, even being a chore, lets put a changeset to let others know what changed ok?

@abhinavkrin abhinavkrin requested a review from ggazzo September 26, 2024 08:47
@abhinavkrin abhinavkrin force-pushed the chore/removed-removeWebdavAccount-method branch from 4303a21 to 174ecfa Compare September 27, 2024 19:02
@ggazzo ggazzo added this to the 7.0 milestone Oct 1, 2024
@ggazzo ggazzo force-pushed the chore/removed-removeWebdavAccount-method branch from 174ecfa to 6f665e5 Compare October 1, 2024 01:04
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 1, 2024
@ggazzo ggazzo merged commit b1f6559 into release-7.0.0 Oct 1, 2024
11 of 12 checks passed
@ggazzo ggazzo deleted the chore/removed-removeWebdavAccount-method branch October 1, 2024 01:04
ggazzo pushed a commit that referenced this pull request Oct 8, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
39236e9 
Signed-off-by: Abhinav Kumar <[email protected]>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
@abhinavkrin @sampaiodiego
chore!: removed removeWebdavAccount method (#33355)
32823bf 
Signed-off-by: Abhinav Kumar <[email protected]>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
@abhinavkrin @sampaiodiego
chore!: removed removeWebdavAccount method (#33355)
c11a535 
Signed-off-by: Abhinav Kumar <[email protected]>
abhinavkrin added a commit that referenced this pull request Oct 11, 2024
@abhinavkrin
chore!: removed removeWebdavAccount method (#33355)
b73d0d5 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
8c4068a 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
45cb43e 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
e2edb9e 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
b62877c 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
9d8661b 
Signed-off-by: Abhinav Kumar <[email protected]>
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
@abhinavkrin @MartinSchoeler
chore!: removed removeWebdavAccount method (#33355)
aeecdda 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
61d857c 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
914a406 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
2511b8b 
Signed-off-by: Abhinav Kumar <[email protected]>
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin added a commit that referenced this pull request Oct 25, 2024
@abhinavkrin
chore!: removed removeWebdavAccount method (#33355)
d30359b 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
5b27e11 
Signed-off-by: Abhinav Kumar <[email protected]>
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
@abhinavkrin @ggazzo
chore!: removed removeWebdavAccount method (#33355)
c047ff9 
Signed-off-by: Abhinav Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavkrin @ggazzo